Codecov Report

Merging #556 (298cd9f) into master (217b487) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          696       698    +2     
  Branches       218       220    +2     
=========================================
+ Hits           696       698    +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217b487...462a5a8. Read the comment docs.

Thanks for the report. Yes, we should exclude hidden elements. :)

But while elements with hidden attribute should not contain elements that are relevant for the user, they are still displayed and available if a stylesheet overwrites display.

<input/>
<button hidden style="display: inline-block">click</button>
<input />

So we need to traverse the ancestors and verify if they are visible.

I've opened benadamstyles#1 with a solution.
But the bug in jsdom causing window.getComputedStyle() to ignore hidden attributes has to be resolved first.

Replaced by #579